Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List metrics forwarded to the sumologic #629

Merged
merged 11 commits into from
May 26, 2020
Merged

Conversation

sumo-drosiek
Copy link
Contributor

Description

Add list of metrics which we forward to the sumologic

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek added this to the v1.1 milestone May 15, 2020
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like this idea, a lot because it is clear. Left on comment. Also cc @arunpatyal - might be worth comparing to your doc, this way we can be clear about what data we collect.

# prometheus_remote_storage_shards_min
# prometheus_remote_storage_string_interner_zero_reference_releases_total
# prometheus_remote_storage_succeeded_samples_total
# up
- url: http://$(CHART).$(NAMESPACE).svc.cluster.local:9888/prometheus.metrics
writeRelabelConfigs:
- action: keep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing fluentd/bit/otel?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was basing on metrics test. Need to run setup with logs and tracing to do full completion

@sumo-drosiek
Copy link
Contributor Author

Solves #603

Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add the one's present in the last remote write queue as well

# prometheus_remote_storage_shards_min
# prometheus_remote_storage_string_interner_zero_reference_releases_total
# prometheus_remote_storage_succeeded_samples_total
# up
- url: http://$(CHART).$(NAMESPACE).svc.cluster.local:9888/prometheus.metrics
writeRelabelConfigs:
- action: keep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given pending comments

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it :)
Please re-request the review when the comments issues are fixed.

@sumo-drosiek
Copy link
Contributor Author

I updated list of metrics with fluentd, fluent-bit and otelcol :)

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :)
image

@sumo-drosiek sumo-drosiek merged commit b882544 into master May 26, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-list-metrics branch May 26, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants