Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc Updates #686

Merged
merged 41 commits into from
Jul 30, 2020
Merged

Doc Updates #686

merged 41 commits into from
Jul 30, 2020

Conversation

frankreno
Copy link
Contributor

@frankreno frankreno commented May 27, 2020 •
edited
Loading

Description

Doc updates for Helm3 and major refactoring.

TODO:

  • Document new parameters for 1.1 release
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@frankreno
Initial commit. Docs refactoring.
c32e1ba 
  * Document configurable parameters and respective defaults.
  * Refactor Helm install, adding Helm3.
@frankreno frankreno marked this pull request as draft May 27, 2020 14:41
@frankreno frankreno changed the title helm3-doc-updates Doc Updates May 27, 2020
vsinghal13
vsinghal13 reviewed May 29, 2020
View reviewed changes
deploy/docs/Installation_with_Helm.md Outdated Show resolved Hide resolved
deploy/docs/Installation_with_Helm.md Outdated Show resolved Hide resolved
deploy/docs/Installation_with_Helm.md Outdated Show resolved Hide resolved
deploy/docs/Installation_with_Helm.md Outdated Show resolved Hide resolved
deploy/docs/Installation_with_Helm.md Outdated Show resolved Hide resolved
deploy/docs/HelmChartConfigiuration.md Outdated Show resolved Hide resolved
This was linked to issues Jun 4, 2020
Helm Install, "Error: create: failed to create: namespaces "sumologic" not found" #571
Closed
Helm Install "Error: unknown flag: --name" #570
Closed
installing with helm: --namespace not used in helm 3 #368
Closed
perk-sumo
perk-sumo approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for some small things, thank you!

@frankreno
Helm3 has fixed the namespace issue so update steps. Also port in mis…
84dc52f 
…sed content in the different installs for parity. Update non-helm install with improvements.
@frankreno
Fix formatting
2c1a944
samjsong
samjsong reviewed Jun 24, 2020
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks amazing, thanks Frank! left a few comments in the non-helm doc, otherwise LGTM

deploy/docs/Non_Helm_Installation.md Show resolved Hide resolved
deploy/docs/Non_Helm_Installation.md Show resolved Hide resolved
@frankreno frankreno added this to the v1.1 milestone Jul 10, 2020
@bergerx bergerx mentioned this pull request Jul 18, 2020
Closed
@perk-sumo
Copy link
Contributor

Please make sure to squash the commits on merge (using the Squash and merge button).

@frankreno frankreno merged commit 142aa6d into master Jul 30, 2020
@frankreno frankreno deleted the helm3-doc-updates branch July 30, 2020 16:08
@perk-sumo perk-sumo mentioned this pull request Jul 30, 2020
Closed
@kasia-kujawa kasia-kujawa mentioned this pull request Jan 25, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

@drduke1 drduke1 drduke1 approved these changes

@samjsong samjsong samjsong approved these changes

@vsinghal13 vsinghal13 vsinghal13 approved these changes

Assignees
No one assigned
Labels
do-not-merge/hold documentation documentation
Projects
None yet
Milestone
v1.1
6 participants
@frankreno @perk-sumo @drduke1 @samjsong @vsinghal13 @sumo-drosiek