Add generator for logs, events and traces sources #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
force-pushed
the
drosiek-logs-events-traces-sources
branch
2 times, most recently
from
6be69f7
to
1a1ce8f
Compare
sumo-drosiek
changed the title
perk-sumo
force-pushed
the
drosiek-terraform-source-fields
branch
from
d859b1b
to
9286794
Compare
sumo-drosiek
force-pushed
the
drosiek-logs-events-traces-sources
branch
from
1a1ce8f
to
413dc41
Compare
3 tasks
sumo-drosiek
commented
Jun 4, 2020
sumo-drosiek
force-pushed
the
drosiek-logs-events-traces-sources
branch
3 times, most recently
from
6d1b64c
to
7bfc4e5
Compare
|
Forgot about upgrading docker image |
perk-sumo
reviewed
Jun 5, 2020
| @@ -39,6 +39,8 @@ spec: | |||
| env: | |||
| - name: GOGC | |||
| value: "80" | |||
| {{- $ctx := .Values -}} | |||
| {{ include "fluentd.envs" (dict "Context" $ctx "Type" "traces")}} | |||
There was a problem hiding this comment.
Why do we call it flutend.envs if we use it for otelcol as well?
There was a problem hiding this comment.
because we didn't use it for otelcol before 😅
perk-sumo
reviewed
Jun 5, 2020
sumo-drosiek
force-pushed
the
drosiek-logs-events-traces-sources
branch
from
5eb17ab
to
004db9a
Compare
sumo-drosiek
force-pushed
the
drosiek-logs-events-traces-sources
branch
from
fe2ce8a
to
161345a
Compare
|
Close and reopen due to ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Auto-generate logs, events and traces endpoints in terraform
It doesn't add automatic usage of these sources in fluentd. It has to be done manually
This PR is made almost on the top of the #705
Testing performed