Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split sumo-k8s.tf on multiple terraform files #721

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Conversation

sumo-drosiek
Copy link
Contributor

Description

Split sumo-k8s.tf on multiple terraform files

Due to generation way (two loops) I decided to not split those files for metrics/traces/logs

Fixes #696

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek mentioned this pull request Jun 9, 2020
3 tasks
@sumo-drosiek sumo-drosiek added this to the v1.1 milestone Jun 9, 2020
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vsinghal13 vsinghal13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@perk-sumo perk-sumo merged commit a460f77 into master Jun 10, 2020
@perk-sumo perk-sumo deleted the drosiek-split-tf branch June 10, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split sumo-k8s.tf on several files
4 participants