Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sumologic.com as prefix for internal labels #734

Merged
merged 3 commits into from
Jun 16, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

I observed during review that we already use 'sumologic.com/' prefix in annotations so it would be better to stick that convention for internal labels

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any upgrade issues with this change?

@sumo-drosiek
Copy link
Contributor Author

I want to put it into 1.1 so shouldn't be any

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks better IMO. Thank you! 👍

@perk-sumo perk-sumo merged commit abe12f7 into master Jun 16, 2020
@perk-sumo perk-sumo deleted the drosiek-consistent-labeling branch June 16, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants