Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Severity1 fix 741 #745

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Severity1 fix 741 #745

merged 3 commits into from
Jun 25, 2020

Conversation

severity1
Copy link
Contributor

Description

Normally in helm the namespace is created automatically or beforehand, in most cases organizations will want to add metadata to their namespace for auditing and automating purposes. Sumologic's helm setup job makes this impossible as it recreates the namespace thus removing all the metadata added beforehand. This PR's intention is to remove this responsibility from sumologic's helm.

@sumo-drosiek
Copy link
Contributor

LGTM, Thank you for the PR 👍

@sumo-drosiek
Copy link
Contributor

@severity1 Just one ask, could you squash the commits please?

Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @severity1 for your PR!

@perk-sumo
Copy link
Contributor

@sumo-drosiek let's use the squash-and-merge from GH once @frankreno approves.

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@perk-sumo perk-sumo merged commit 9c4e52f into SumoLogic:master Jun 25, 2020
@severity1
Copy link
Contributor Author

thanks team!

@severity1 severity1 deleted the severity1-fix-741 branch June 25, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants