Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last fixes for values.yaml #844

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Last fixes for values.yaml #844

merged 2 commits into from
Aug 21, 2020

Conversation

perk-sumo
Copy link
Contributor

Description

Some gold-plating for values.yaml:

  • Fix: start text comments with two hash characters - leftovers after c9233bd
  • Fix indentation for extraEnvVars examples
Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@perk-sumo perk-sumo added this to the v1.2 milestone Aug 21, 2020
@perk-sumo perk-sumo changed the title Perk last fixes for values Last fixes for values.yaml Aug 21, 2020
@perk-sumo perk-sumo merged commit cc2ff86 into master Aug 21, 2020
@perk-sumo perk-sumo deleted the perk-last-fixes-for-values branch August 21, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek-sumo pmalek-sumo pmalek-sumo approved these changes

@frankreno frankreno Awaiting requested review from frankreno

@samjsong samjsong Awaiting requested review from samjsong

@vsinghal13 vsinghal13 Awaiting requested review from vsinghal13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@perk-sumo @pmalek-sumo