Set text compress as default option for FluentD file buffer #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
a team,
vsinghal13,
perk-sumo and
pmalek-sumo
and removed request for
a team
sumo-drosiek
force-pushed
the
drosiek-disable-fluentd-buffer-compression
branch
2 times, most recently
from
ecb9b9f
to
9f28027
Compare
vsinghal13
approved these changes
Aug 24, 2020
frankreno
approved these changes
Aug 24, 2020
| @@ -211,6 +211,7 @@ fluentd: | |||
| totalLimitSize: "128m" | |||
| retryMaxInterval: "10m" | |||
| retryForever: true | |||
| compress: text | |||
There was a problem hiding this comment.
Should we add a comment that GZIP is not supported so it is clear why we set it this way?
There was a problem hiding this comment.
@frankreno I would say not recommended and point to the issue. Is it ok?
|
@vsinghal13 it was 10 times for my test data. It will be compression rate of the gzip for the given log files |
sumo-drosiek
force-pushed
the
drosiek-disable-fluentd-buffer-compression
branch
from
82eaeb2
to
5d6510c
Compare
perk-sumo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set text compress as default due to fluent/fluentd#3110
Testing performed