Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm chart configuration doc with podLabels and podAnnotations changes #857

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

pmalek-sumo
Copy link
Contributor

Description

This updates helm chart configuration doc with changes introduced in #822 and #819

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek
Copy link
Contributor

We need to include information about --force flag somehow 🤔

Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmalek-sumo
Copy link
Contributor Author

Let's handle the --force documentation in another PR when we have it obvious when it helps and when it doesn't

@pmalek-sumo pmalek-sumo merged commit 7a7b77c into master Aug 28, 2020
@pmalek-sumo pmalek-sumo deleted the update-helm-chart-configuration-doc branch August 28, 2020 13:01
@perk-sumo perk-sumo added this to the v1.2 milestone Aug 28, 2020
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants