Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure Helm overrides directory #88

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Restructure Helm overrides directory #88

merged 1 commit into from
Jul 25, 2019

Conversation

rvmiller89
Copy link
Contributor

Currently we have:

deploy/fluent-bit/overrides.yaml
deploy/helm/overrides.yaml
deploy/helm/tiller-rbac.yaml

This PR changes it to:

deploy/helm/fluent-bit-overrides.yaml
deploy/helm/prometheus-overrides.yaml
deploy/helm/tiller-rbac.yaml

Discussion: https://sumologic.slack.com/archives/GFJ6U4SCE/p1564015044029100

This PR also removes the original overrides.yaml files and replaces them with soft links to the new files, which we can keep around for a while, so that customers using the old instructions can still download those original overrides.yaml files.

samjsong
samjsong approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@samjsong samjsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ryan!

frankreno
frankreno approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvmiller89 rvmiller89 merged commit e9c34b2 into master Jul 25, 2019
@rvmiller89 rvmiller89 deleted the rmiller-restructure-helm-overrides branch July 25, 2019 19:48
psaia pushed a commit to psaia/sumologic-kubernetes-collection that referenced this pull request May 25, 2021
@agiaccone @mlclmj
Add sumologic to new itunes third party service (SumoLogic#88)
e426797 
Co-authored-by: Malcolm Jones <17786500+mlclmj@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@samjsong samjsong samjsong approved these changes

@lei-sumo lei-sumo Awaiting requested review from lei-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvmiller89 @frankreno @samjsong