Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prometheus configuration #883

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Fix prometheus configuration #883

merged 2 commits into from
Sep 3, 2020

Conversation

sumo-drosiek
Copy link
Contributor

Description

Fix prometheus configuration

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@sumo-drosiek sumo-drosiek requested review from pmalek-sumo, a team, samjsong and vsinghal13 and removed request for a team September 3, 2020 14:05
@sumo-drosiek
Copy link
Contributor Author

Fixes #882

@sumo-drosiek sumo-drosiek linked an issue Sep 3, 2020 that may be closed by this pull request
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦🏻

LGTM

@sumo-drosiek sumo-drosiek merged commit 1cae4ff into master Sep 3, 2020
@sumo-drosiek sumo-drosiek deleted the drosiek-fix-proemtheus branch September 3, 2020 14:24
@perk-sumo perk-sumo added this to the v1.2 milestone Sep 3, 2020
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prometheus error: labeldrop action requires only 'regex'
3 participants