Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all securityContext resources #889

Merged
merged 2 commits into from
Sep 15, 2020
Merged

Support all securityContext resources #889

merged 2 commits into from
Sep 15, 2020

Conversation

andrzej-stencel
Copy link
Contributor

Fixes #786

sumo-drosiek
sumo-drosiek approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash all you commits

@andrzej-stencel andrzej-stencel force-pushed the astencel-Support-all-securityContext-values branch 3 times, most recently from 522d960 to dff814f Compare September 10, 2020 07:06
perk-sumo
perk-sumo approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@perk-sumo perk-sumo added this to the v1.3 milestone Sep 10, 2020
frankreno
frankreno approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@frankreno frankreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrzej-stencel andrzej-stencel force-pushed the astencel-Support-all-securityContext-values branch 2 times, most recently from 9fd9351 to 66cbdc3 Compare September 15, 2020 09:02
@andrzej-stencel andrzej-stencel merged commit 5a0c3d5 into master Sep 15, 2020
@andrzej-stencel andrzej-stencel deleted the astencel-Support-all-securityContext-values branch September 15, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankreno frankreno frankreno approved these changes

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

@pmalek-sumo pmalek-sumo Awaiting requested review from pmalek-sumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Support for Security Context for containers in sumologic-kubernetes-collection
4 participants
@andrzej-stencel @frankreno @sumo-drosiek @perk-sumo