-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename sumologic to sumo-make and add bash completion #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
requested review from
perk-sumo,
pmalek-sumo and
andrzej-stencel
September 11, 2020 13:55
pmalek-sumo
reviewed
Sep 11, 2020
sumo-drosiek
force-pushed
the
drosiek-vagrant-sumomake
branch
from
September 11, 2020 14:19
cf9b509
to
ddbc121
Compare
pmalek-sumo
approved these changes
Sep 11, 2020
andrzej-stencel
approved these changes
Sep 11, 2020
perk-sumo
reviewed
Sep 16, 2020
perk-sumo
reviewed
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅 for completion but let's talk a bit more on the sumomake
vs sumo-make
please :)
sumo-drosiek
force-pushed
the
drosiek-vagrant-sumomake
branch
from
September 16, 2020 11:12
ddbc121
to
12c974e
Compare
sumo-drosiek
changed the title
Rename sumologic to sumomake and add bash completion
Rename sumologic to sumo-make and add bash completion
Sep 16, 2020
sumo-drosiek
force-pushed
the
drosiek-vagrant-sumomake
branch
from
September 16, 2020 11:27
12c974e
to
1194a6e
Compare
sumo-drosiek
force-pushed
the
drosiek-vagrant-sumomake
branch
from
September 16, 2020 11:28
1194a6e
to
fcb3db2
Compare
pmalek-sumo
approved these changes
Sep 16, 2020
perk-sumo
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename sumologic to sumomake and add bash completion
Testing performed