-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not proxy kubernetes internal traffic #920
Conversation
460ebaf
to
66e53d8
Compare
Fixes #914 |
@@ -32,6 +32,8 @@ sumologic: | |||
## proxy urls | |||
httpProxy: "" | |||
httpsProxy: "" | |||
## Exclude kubernetes internal traffic from proxy | |||
noProxy: kubernetes.default.svc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this approach it is cleaner. Con is that if a customer has a different url where they customize the host in the TF kubernetes provider, they have to also update this. Any way to have one property to control both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the cluster endpoint be excluded from the proxy every time?
I can merge both of the config options in helm, but there will be no way to include the kubernetes url then (to proxy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh ok fair point. In that case we can leave it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
66e53d8
to
0e017ce
Compare
b54a9f6
to
0e7947f
Compare
* Do not proxy kubernetes internal traffic * Update terraform tests * Generate new 'setup-sumologic.yaml.tmpl' Co-authored-by: Travis CI <travis@travis-ci.org>
* Do not proxy kubernetes internal traffic * Update terraform tests
Description
Do not proxy kubernetes internal traffic
Testing performed