Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add resource limits for prometheus container #959

Merged
merged 3 commits into from
Sep 29, 2020
Merged

add resource limits for prometheus container #959

merged 3 commits into from
Sep 29, 2020

Conversation

vsinghal13
Copy link
Contributor

Description

Fill in your description here.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@vsinghal13 vsinghal13 mentioned this pull request Sep 29, 2020
Closed
3 tasks
@vsinghal13
Copy link
Contributor Author

In the earlier PR, by mistake I modified the overrides.yaml and the CI is giving error, so created a new one.

@perk-sumo perk-sumo added this to the v1.3 milestone Sep 29, 2020
@sumo-drosiek sumo-drosiek mentioned this pull request Sep 29, 2020
Closed
@sumo-drosiek sumo-drosiek linked an issue Sep 29, 2020 that may be closed by this pull request
Prometheus container has no limits set by default #885
Closed
@sumo-drosiek
Copy link
Contributor

Fixes #885

perk-sumo
perk-sumo approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@perk-sumo perk-sumo merged commit 4530926 into master Sep 29, 2020
@perk-sumo perk-sumo deleted the vsinghal13-patch-1 branch September 29, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

@frankreno frankreno Awaiting requested review from frankreno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Prometheus container has no limits set by default
3 participants
@vsinghal13 @sumo-drosiek @perk-sumo