Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for vagrant disksize plugin in Vagrantfile #996

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Add check for vagrant disksize plugin in Vagrantfile #996

merged 1 commit into from
Oct 9, 2020

Conversation

pmalek-sumo
Copy link
Contributor

Description

If user has vagrant-disksize plugin missing he'll get an error saying:

Bringing machine 'default' up with 'virtualbox' provider...
There are errors in the configuration of this machine. Please fix
the following errors and try again:

Vagrant:
* Unknown configuration section 'disksize'.

This PR catches this explicitly and suggests how to install said plugin.

Testing performed
  • ci/build.sh
  • Redeploy fluentd and fluentd-events pods
  • Confirm events, logs, and metrics are coming in

@pmalek-sumo pmalek-sumo self-assigned this Oct 9, 2020
sumo-drosiek
sumo-drosiek approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😮

@pmalek-sumo pmalek-sumo merged commit e50d4c5 into master Oct 9, 2020
@pmalek-sumo pmalek-sumo deleted the vagrantfile-check-disksize-plugin branch October 9, 2020 09:32
perk-sumo
perk-sumo reviewed Oct 9, 2020
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perk-sumo perk-sumo perk-sumo left review comments

@andrzej-stencel andrzej-stencel andrzej-stencel left review comments

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

Assignees

@pmalek-sumo pmalek-sumo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmalek-sumo @sumo-drosiek @perk-sumo @andrzej-stencel @pmalek