Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set async version in Dockerfile for Alpine #571

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix: set async version in Dockerfile for Alpine #571

merged 1 commit into from
Jul 26, 2023

Conversation

aboguszewski-sumo
Copy link
Contributor

@aboguszewski-sumo aboguszewski-sumo commented Jul 25, 2023 •
edited
Loading

This fixes failing runs for Alpine.

@aboguszewski-sumo aboguszewski-sumo requested a review from a team as a code owner July 25, 2023 15:11
perk-sumo
perk-sumo approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@perk-sumo perk-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add some more information on why this change is helping here (ideally in the commit message).

@aboguszewski-sumo
fix: set async version in Dockerfile for Alpine
aac7a52 
The build was failing because of a too recent version of async, where one function argument was missing.
@aboguszewski-sumo aboguszewski-sumo enabled auto-merge (rebase) July 26, 2023 07:36
@aboguszewski-sumo aboguszewski-sumo merged commit 0bf48d8 into main Jul 26, 2023
10 checks passed
@aboguszewski-sumo aboguszewski-sumo deleted the dev-build/ab-1162 branch July 26, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumo-drosiek sumo-drosiek sumo-drosiek approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aboguszewski-sumo @sumo-drosiek @perk-sumo