Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload of installation script logs #64

Merged
merged 19 commits into from
Jun 3, 2024
Merged

Conversation

ccressent
Copy link
Contributor

Relocating the work from SumoLogic/sumologic-otel-collector#1312 into this repository now that the installation scripts have moved.

ccressent and others added 9 commits April 11, 2024 12:08
The backend does not currently handle `Content-Encoding` headers
properly anymore.
See: https://sumologic.atlassian.net/browse/SUMO-232957
Add --disable-installation-telemetry for Linux
Add -DisableInstallationTelemetry for Windows

Signed-off-by: Cyril Cressent <ccressent@sumologic.com>
Signed-off-by: Cyril Cressent <ccressent@sumologic.com>
Add --installation-logfile-endpoint on Linux
Add -InstallationLogfileEndpoint on Windows

Signed-off-by: Cyril Cressent <ccressent@sumologic.com>
@ccressent ccressent marked this pull request as ready for review April 15, 2024 16:55
@ccressent ccressent requested review from a team as code owners April 15, 2024 16:55
@ccressent ccressent self-assigned this Apr 15, 2024
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, these routines are supposed to fail quietly if sending fails, which is why tests pass. Can we add a test which starts a small webserver, sets the endpoint to that webserver, and then asserts that it got some data?

install-script/install.sh Show resolved Hide resolved
install-script/install.ps1 Outdated Show resolved Hide resolved
@ccressent
Copy link
Contributor Author

@swiatekm-sumo
Are we good to merge this?

Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about temp file placement on Linux and Darwin, LGTM otherwise.

install-script/install.sh Outdated Show resolved Hide resolved
@ccressent ccressent merged commit 74ff6d8 into main Jun 3, 2024
39 checks passed
@ccressent ccressent deleted the 222461-installation-logs branch June 3, 2024 17:43
amdprophet added a commit that referenced this pull request Jul 3, 2024
amdprophet added a commit that referenced this pull request Jul 4, 2024
Revert "Merge pull request #64 from SumoLogic/222461-installation-logs"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants