-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add upload of installation script logs #64
Conversation
The backend does not currently handle `Content-Encoding` headers properly anymore. See: https://sumologic.atlassian.net/browse/SUMO-232957
Add --disable-installation-telemetry for Linux Add -DisableInstallationTelemetry for Windows Signed-off-by: Cyril Cressent <ccressent@sumologic.com>
Signed-off-by: Cyril Cressent <ccressent@sumologic.com>
Add --installation-logfile-endpoint on Linux Add -InstallationLogfileEndpoint on Windows Signed-off-by: Cyril Cressent <ccressent@sumologic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, these routines are supposed to fail quietly if sending fails, which is why tests pass. Can we add a test which starts a small webserver, sets the endpoint to that webserver, and then asserts that it got some data?
This is for the shellscript only since the PowerShell script already does that.
Signed-off-by: Cyril Cressent <ccressent@sumologic.com>
@swiatekm-sumo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about temp file placement on Linux and Darwin, LGTM otherwise.
ffc07fc
to
42cd587
Compare
Revert "Merge pull request #64 from SumoLogic/222461-installation-logs"
Relocating the work from SumoLogic/sumologic-otel-collector#1312 into this repository now that the installation scripts have moved.