Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove install scripts #1536

Merged
merged 1 commit into from
Apr 15, 2024
Merged

chore: remove install scripts #1536

merged 1 commit into from
Apr 15, 2024

Conversation

swiatekm
Copy link

The scripts have been moved to the packaging repository. We still attach them to releases, but we use the version stored in that repository. There is no reason to keep them here anymore.

@swiatekm swiatekm marked this pull request as ready for review April 10, 2024 12:45
@swiatekm swiatekm requested a review from a team as a code owner April 10, 2024 12:45
@rnishtala-sumo
Copy link
Contributor

rnishtala-sumo commented Apr 10, 2024

@swiatekm-sumo just want to confirm that this action will still upload the install script artifact because it's now available in SumoLogic/sumologic-otel-collector-packaging and that our collector releases will still include this as an asset? I think the collector installation workflow in the UI depends on it.

@swiatekm
Copy link
Author

@swiatekm-sumo just want to confirm that this action will still upload the install script artifact because it's now available in SumoLogic/sumologic-otel-collector-packaging and that our collector releases will still include this as an asset? I think the collector installation workflow in the UI depends on it.

Yes, it will. You can see it happen for dev builds, here for example: https://github.com/SumoLogic/sumologic-otel-collector/actions/runs/8643263953.

The scripts have been moved to the packaging repository. We still attach
them to releases, but we use the version stored in that repository.
There is no reason to keep them here anymore.
@swiatekm swiatekm enabled auto-merge (rebase) April 15, 2024 16:13
@swiatekm swiatekm merged commit 8397091 into main Apr 15, 2024
30 checks passed
@swiatekm swiatekm deleted the chore/drop-install-scripts branch April 15, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants