Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back deleted docker-compose.yml #1825

Merged

Conversation

DmitrySychev
Copy link
Contributor

Description

Please include:
I'm not sure why this docker-compose.yml was deleted in the first place. Nearly half of the instructions in the readme for this repo rely on this file being there.

Essentially, it's just another way to start up the container using docker compose . This makes the container much more usable for power users, as they'd be able to configure volumes much easier. Also, instead of having to remember the whole complicated docker container run --rm -d -p 8501:8501 -e STREAMLIT_SERVER_HEADLESS=true -e "WEBUI_SCRIPT=webui_streamlit.py" -e "VALIDATE_MODELS=false" -v "${PWD}/outputs:/sd/outputs" --gpus all tukirito/sygil-webui:latest command, it's as simple as running docker compose start or up, since all of the configs are in the compose file, you wouldn't need anything else. The compose file has been tested and runs without any issues. The readme instructions can stay mostly as is.

Additionally, as mentioned before, the readme instructions rely heavily on docker compose. If the repo creators wish to not include docker compose, then it should all be omitted from the readme, as it makes this extremely confusing for any user.

Closes: # (issue)

Checklist:

  • I have changed the base branch to dev
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

@yiqiangjun
Copy link

yiqiangjun commented Nov 26, 2023 via email

Copy link

sweep-ai bot commented Nov 26, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@ZeroCool940711
Copy link
Contributor

Hey, thanks for the PR, a lot of people have been asking for this but honestly I'm not good with docker so I was not able to fix it myself, really appreciate your PR. I think we should first merge it to the dev branch and then to main so all the changes in the dev branch are on main. I will be changing the bran on this PR to the dev branch and then merging it and also merging dev to main afterward.

@ZeroCool940711 ZeroCool940711 changed the base branch from master to dev November 26, 2023 05:31
@ZeroCool940711 ZeroCool940711 merged commit 1b0e046 into Sygil-Dev:dev Nov 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants