Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker multiarch #93

Merged
merged 10 commits into from
Oct 3, 2020
Merged

Docker multiarch #93

merged 10 commits into from
Oct 3, 2020

Conversation

simonmicro
Copy link
Contributor

  • This will temporary break the docker builds, until I reconfigure the build properties inside the docker repo
  • This will not modify the current tags, just add new - until the configuration is corrected (also inside the docker repo)
  • Tested on amd64 and arm32v6
  • ANY further change of the Dockerfiles need to be done inside EVERY file for EVERY architecture from now on

This implements #92

@simonmicro
Copy link
Contributor Author

I object - according to https://docs.docker.com/engine/reference/builder/#maintainer-deprecated the MAINTAINER command is deprecated (and at the moment it is not even shown inside the docker manifests anymore). If you wish to be listed as maintainer I / you could use the LABEL (I am very sorry, that I removed the command, but I thought it would be better to remove the deprecated stuff when I am at it...). I did not do that, because from my perspective the git history is enough...

@simonmicro
Copy link
Contributor Author

@6ec123321 Okay, thanks! I again emphasize that, if you wish, you can add yourself back using LABEL. I did not intended to claim your work as mine. But yeah, we'll see what @SystemRage thinks about that 😀, I hope he will just accept the PR soon...

@SystemRage
Copy link
Owner

Only one thing before merging, if you can remove gimp files.
png images are enough.

@simonmicro
Copy link
Contributor Author

@SystemRage Here you go!

@SystemRage SystemRage merged commit 5ffcbb8 into SystemRage:master Oct 3, 2020
@simonmicro simonmicro deleted the docker-multiarch branch October 3, 2020 22:15
edgd1er pushed a commit to edgd1er/py-kms that referenced this pull request Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants