Add Get_Flags Function to Modem #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstabrawa
reviewed
Mar 2, 2021
| return Msg.UNKNOWN | ||
| if isinstance(msg, Msg.OutGetModemFlags): | ||
| if msg.is_ack: | ||
| LOG.ui("Modem flag byte is: %s, spare bytes are: %s, %s", |
There was a problem hiding this comment.
It may be more useful to print flags/spares in hex (assuming the conversion to string does so in decimal by default).
| if self.is_ack is not None: | ||
| ack = " ack: %s" % str(self.is_ack) | ||
| flags = " modem flags: %s" % str(self.modem_flags) | ||
| spares = " spares: %s %s" % (str(self.spare1), str(self.spare2)) |
There was a problem hiding this comment.
It may be more useful to print flags/spares in hex (assuming the conversion to string does so in decimal by default).
| handler.sending_message(msg) | ||
| assert handler._PLM_sent | ||
|
|
||
| #Try a message prior to sent |
There was a problem hiding this comment.
This one is actually after sending ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds support for the
get_flagscommand on the modem. The value is only outputted to the log and the UI, it is not saved.Additional information
This may be helpful for debugging obscure modem issues, or might be useful in the future.
Checklist