Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add On Off Command Support to Fan Group on FanLinc #400

Merged
merged 1 commit into from
May 16, 2021

Conversation

krkeegan
Copy link
Collaborator

Proposed change

Adds support for on and off commands for the fanlinc.

Expands on PR #399.

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass.

@krkeegan
Copy link
Collaborator Author

Multigroup devices need additional code to handle the on off commands. It isn't clear if this can be abstracted to a single code base. Currently, fan_linc and outlet look very similar. Keypadlincs also have multigroup support, but they use a different command to achieve this.

Likely if another device similar to the fan_linc and outlet are added, we should move these multigroup commands to their own abstract class.

@krkeegan krkeegan merged commit 79c8631 into TD22057:dev May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant