-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow sending raw commands to devices #413
Conversation
I can understand how something like this would be helpful. I think you should allow a full extended message to be defined, not just all zero bytes. That gets a bit unweildy from the command line, but from a json mqtt message, the extended bytes can just be a list. |
It does allow full extended commands - the mqtt message takes a data list, and the cli takes a |
Ahh, I messed that. That is perfect then. Yes, this would have been quite helpful at times. I had failed to realize it could be added so easily. |
Cool beans, I'll add some docs and tests to get this ready to merge. I'll also move the pad/trim logic to the message handler, and may switch the cmd name to |
I don't have a name preference. I can see a value in either. |
Looks good to me, unless you have any more changes I will merge. |
I think it's good to go, feel free to merge away :-) |
This works in my setup. I didn't test extensively, but a basic test of standard commands worked as expected. Thank you for this, it is very helpful. |
Proposed change
This arose while debugging #411 (and messing around with the other commands I found in the command tables). Essentially I found it a lot easier to debug the actual commands when I had the ability to send raw insteon commands through mqtt
I don't think this is a common use case, and there's some cleanup that needs to happen if this were desired (tests, docs, etc); but am happy to work through those if this is would be desired
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: