Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda updates #256

Merged
merged 2 commits into from
May 31, 2018
Merged

Lambda updates #256

merged 2 commits into from
May 31, 2018

Conversation

retgits
Copy link
Contributor

@retgits retgits commented May 31, 2018

What kind of change does this PR introduce? (check one with "x")

[] Bugfix
[X] Feature
[] Code style update (formatting, local variables)
[] Refactoring (no functional changes, no api changes)
[] Other... Please describe:

What is the current behavior? In the current Lambda trigger, the object returned to the caller is an object meaning you can only have a JSON object as a response. For some Gateway operations that might not be the best approach. Also the string that is sent back, is URL encoded which isn't great for API gateway responses where the body shouldn't be URL encoded.

What is the new behavior?

  • The reply is now type any in the trigger.json
  • There is a switch statement in the API Gateway response, if the response is of type string it won't decode it to a JSON object

@retgits retgits requested a review from mellistibco May 31, 2018 21:01
@retgits retgits merged commit 0f60de4 into master May 31, 2018
@retgits retgits deleted the lambda-update branch May 31, 2018 21:19
@mellistibco mellistibco added this to the 0.5.5 milestone Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants