Skip to content

Commit

Permalink
[wasm] Re-enable some tests in the System.Net.WebSockets.Tests namesp…
Browse files Browse the repository at this point in the history
…ace (dotnet#40004)

There is no repro for dotnet#38807 at the moment so the related tests have been enabled.
Two tests have been disabled due to PNSE (see dotnet#39346).

Fixes: dotnet#38807 

The test run result: `Tests run: 177, Errors: 0, Failures: 0, Skipped: 0.`
  • Loading branch information
MaximLipnin committed Jul 29, 2020
1 parent a352aef commit 6ab00b4
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ public async Task ReceiveAsync_UTF8SplitAcrossMultipleBuffers_ValidDataReceived(
}

[Theory]
[PlatformSpecific(~TestPlatforms.Browser)] // System.Net.Sockets is not supported on this platform.
[ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
[InlineData(0b_1000_0001, 0b_0_000_0001, false)] // fin + text, no mask + length == 1
[InlineData(0b_1100_0001, 0b_0_000_0001, true)] // fin + rsv1 + text, no mask + length == 1
Expand Down Expand Up @@ -147,6 +148,7 @@ public async Task ReceiveAsync_InvalidFrameHeader_AbortsAndThrowsException(byte
}

[Fact]
[PlatformSpecific(~TestPlatforms.Browser)] // System.Net.Sockets is not supported on this platform.
[ActiveIssue("https://github.com/dotnet/runtime/issues/34690", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
public async Task ReceiveAsync_ServerSplitHeader_ValidDataReceived()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

namespace System.Net.WebSockets.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/38807", TestPlatforms.Browser)]
public sealed class WebSocketProtocolCreateTests : WebSocketCreateTest
{
protected override WebSocket CreateFromStream(Stream stream, bool isServer, string subProtocol, TimeSpan keepAliveInterval) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

namespace System.Net.WebSockets.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/38807", TestPlatforms.Browser)]
public sealed class WebSocketTests : WebSocketCreateTest
{
protected override WebSocket CreateFromStream(Stream stream, bool isServer, string subProtocol, TimeSpan keepAliveInterval) =>
Expand Down

0 comments on commit 6ab00b4

Please sign in to comment.