Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form과 관련된 Component 구현 #13

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Conversation

sangrimlee
Copy link
Contributor

Pull Request

  • Feature

Summary

진행하신 작업에 대한 내용을 간략하게 작성해주세요.

Describe your changes

  • AuthInput, AuthLayout 스타일 변경
  • Button Component 구현

Issue number and link

ETC

현재 Next.JS의 SWC에서는 styled-components의 cssProp을 지원하지 않습니다.
따로, 사용하려면 SWC가 아니라 Babel을 사용해야하기 때문에, 그냥 CSSProp 타입의 props를 따로 정의해서 사용하였습니다.

- 기본적인 Button Component 뼈대 구현
- TODO: Button을 type or size와 같이 재사용할 수 있게 구현
- Auth Input 스타일 추가
- Focus, Invalid 상태 추가
- 재사용할 수 있게 css Props를 추가
- 현재 Next.JS의 SWC에서는 cssProps Babel Configuration을 지원하지 않아서 따로 CSSProp props를 추가해주었습니다.
- size랑 variant로 추상화
@sangrimlee sangrimlee added the enhancement New feature or request label Jun 23, 2022
@sangrimlee sangrimlee self-assigned this Jun 23, 2022
@sangrimlee sangrimlee changed the title Form과 관련된 Component 구현 (#8) Form과 관련된 Component 구현 Jun 23, 2022
@seongjin2427 seongjin2427 marked this pull request as ready for review June 24, 2022 00:46
- AuthLayout 스타일 추가
- Login Page에 스타일 변경된 것들 반영
- AuthInput의 그림자 제거 및 배경색 추가
Copy link
Contributor

@seongjin2427 seongjin2427 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!!

Copy link
Contributor

@jma1020 jma1020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~~

@jma1020 jma1020 merged commit c158d94 into develop Jun 29, 2022
@jma1020 jma1020 deleted the feature/form-components branch June 29, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants