Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release pipeline to checkout submodules #127

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Update release pipeline to checkout submodules #127

merged 2 commits into from
Jul 13, 2023

Conversation

johausmann
Copy link
Member

The release pipeline was missing the submodule input in the checkout section. Therefore the lineage constellations files were missing in the final wheel pushed to PyPi

Added submodules input to the checkout action to include lineage constellations
@johausmann johausmann requested a review from priesgo July 13, 2023 09:31
@priesgo
Copy link
Member

priesgo commented Jul 13, 2023

Don't we need these files added in the manifest file?

@johausmann
Copy link
Member Author

The mainfest file was already updated with the last merge request.
see here

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7da34a9) 85.61% compared to head (4e5ed2c) 85.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   85.61%   85.61%           
=======================================
  Files          48       48           
  Lines        4964     4964           
=======================================
  Hits         4250     4250           
  Misses        714      714           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@priesgo priesgo merged commit 5ed1413 into main Jul 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants