-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canonical URLS #1004
Canonical URLS #1004
Conversation
Your Testserver will be ready at https://1004.test.live.mm.rbg.tum.de in a few minutes. Logins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, can we have this on the info and login pages as well?
web/template/watch.gohtml
Outdated
@@ -6,6 +6,7 @@ | |||
{{$stream := .IndexData.TUMLiveContext.Stream}} | |||
{{$course := .IndexData.TUMLiveContext.Course}} | |||
<title>{{.IndexData.Branding.Title}} | {{$course.Name}}: {{$stream.Name}}</title> | |||
<link rel="canonical" href="{{.IndexData.CanonicalURL.Stream $course.Slug $stream.ID}}" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to take the version into account (e.g. CAM)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch. thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Motivation and Context
Description
config.yaml
CanonicalURL
which provides canonical urls for the start, course, and watch page<link rel="canonical" href="..">
to start, course, and watch pageSteps for Testing
<head>
includes<link rel="canonical" href="..">
and the URL is correct.