Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mail queue #1058

Merged
merged 7 commits into from
Jun 11, 2023
Merged

Add mail queue #1058

merged 7 commits into from
Jun 11, 2023

Conversation

joschahenningsen
Copy link
Sponsor Member

Motivation and Context

To avoid getting rate limited and to allow retrying failed email sending, we need to store the emails we want to send and send them out buffered.

Description

This PR adds a mail table to the database which contains all emails that should be sent, these are handled one by one with a delay that can be configured.

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Your Testserver will be ready at https://1058.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@joschahenningsen joschahenningsen marked this pull request as ready for review June 7, 2023 09:35
Copy link
Collaborator

@MatthiasReumann MatthiasReumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I guess there isn't an easy way to dry-run this functionality on a large scale (many mails) locally, so we will see if any complaints arise in the future 😬

@joschahenningsen joschahenningsen merged commit 3f2053e into dev Jun 11, 2023
@joschahenningsen joschahenningsen deleted the mailqueue branch June 11, 2023 19:44
SebiWrn pushed a commit that referenced this pull request May 7, 2024
* add mail queue

* test email sending

* enrich email with error logs

* add failed emails to Maintenance page

* fix backoff timing

* lint

* reegn mock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants