Unit tests #1062
Merged
Unit tests #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1062.test.live.mm.rbg.tum.de in a few minutes. Logins
|
joschahenningsen
requested changes
Jun 21, 2023
api/progress.go
Outdated
| @@ -176,8 +177,16 @@ func (r progressRoutes) markWatched(c *gin.Context) { | |||
| } | |||
|
|
|||
| func (r progressRoutes) getProgressBatch(c *gin.Context) { | |||
| tumLiveContext := c.MustGet("TUMLiveContext").(tools.TUMLiveContext) | |||
| ctx, exists := c.Get("TUMLiveContext") | |||
There was a problem hiding this comment.
Was there an issue with the MustGet approach?
There was a problem hiding this comment.
For the progress API we don't use a middleware as tools.InitCourse(daoWrapper) and therefore the handler panics every time the context doesn't exists instead of returning 400.
joschahenningsen
approved these changes
Jun 21, 2023
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Add notification tests * Add progress tests * Add course tests * Add more course tests * Remove println * Fix context error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In the last few months we've added a lot of new functionality without implementing associated unit tests. This PR addresses this issue partly (Not all functions can be tested).
Description
Add unit tests.
Steps for Testing
go test / testworkflow on GitHub succeeds