Improvement/refactor course sections #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mono424
requested review from
MatthiasReumann,
joschahenningsen and
alexanderstephan
|
merging #1137 created a few conflicts, can you merge them? |
joschahenningsen
approved these changes
Sep 30, 2023
Mjaethers
pushed a commit
to Mjaethers/gocast
that referenced
this pull request
Nov 3, 2023
* started wit hrefactor of course management * add dao & route * update route * started wit hfetching * Add changeset abstraction * cleanup file * remove get all streams again, as there is AdminJson method * Its rendering * further dev :S * added some directive * little fixes * ... * ... no idea... * right path i guess * changeset working except video sections * fix discard files * save from laptop * Add changeset doku * make private works like charm * changing works pretty well * add video upload * add series update * ported transcoding * add readme and lecture hall select * more description * simplified lecture hall set * linter * more fixes * :) * add attachments * :) * add video sections to admin streams * main functionality * using fetch wrtappers * moved uploadFile and postFormData * fix linteer * Impl. Feedback * add video sections to admin streams * main functionality * using fetch wrtappers * moved uploadFile and postFormData * version workers with tag (TUM-Dev#1157) * fix linteer * fix delete lecture * reenable page reload on create * some linter fixes * fix merge complications * fix changeset; adding onchange listener * fixed adding sections * added directives * fix typo * improved directives * design improvement * fixed creating and deleting * add sections fixed * cleanup * :) * fix alpine js error issues * remoev console log * nested :) * remove console log * lint-fix * fix admin.LectureList initialisation in settings tab --------- Co-authored-by: Joscha Henningsen <44805696+joschahenningsen@users.noreply.github.com> Co-authored-by: Joscha Henningsen <joscha.henningsen@tum.de>
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* started wit hrefactor of course management * add dao & route * update route * started wit hfetching * Add changeset abstraction * cleanup file * remove get all streams again, as there is AdminJson method * Its rendering * further dev :S * added some directive * little fixes * ... * ... no idea... * right path i guess * changeset working except video sections * fix discard files * save from laptop * Add changeset doku * make private works like charm * changing works pretty well * add video upload * add series update * ported transcoding * add readme and lecture hall select * more description * simplified lecture hall set * linter * more fixes * :) * add attachments * :) * add video sections to admin streams * main functionality * using fetch wrtappers * moved uploadFile and postFormData * fix linteer * Impl. Feedback * add video sections to admin streams * main functionality * using fetch wrtappers * moved uploadFile and postFormData * version workers with tag (#1157) * fix linteer * fix delete lecture * reenable page reload on create * some linter fixes * fix merge complications * fix changeset; adding onchange listener * fixed adding sections * added directives * fix typo * improved directives * design improvement * fixed creating and deleting * add sections fixed * cleanup * :) * fix alpine js error issues * remoev console log * nested :) * remove console log * lint-fix * fix admin.LectureList initialisation in settings tab --------- Co-authored-by: Joscha Henningsen <44805696+joschahenningsen@users.noreply.github.com> Co-authored-by: Joscha Henningsen <joscha.henningsen@tum.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1137 made the code shorter and brought it in a better and reactive structure. The videosections have been following an own update cycle. It would be nice to have one united update cycle experience for a lecture. Giving the user the opportunity to discard or save all changed data by one button.
Description
Integrated the course section editing to the lecture edit section.
Steps for Testing
Screenshots
Super reactive UX with
change-set&DataProvidersBildschirmaufnahme.2023-09-15.um.17.43.22.mov
Complex reactive validation
Bildschirmaufnahme.2023-09-15.um.20.39.54.mov
also fixes #1178