Added close button to settings - working with browser history #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1204.test.live.mm.rbg.tum.de in a few minutes. Logins
|
alexanderstephan
approved these changes
Oct 25, 2023
|
Btw, you might want to set your git config properly. As no email is set, your commit is not linked to your account. |
alexanderstephan
deleted the
1181-button-to-quit-the-settings-at-httpsliverbgtumdesettings
branch
YiranDuan721
pushed a commit
that referenced
this pull request
Oct 25, 2023
Co-authored-by: Sebastian <sebwirn@web.de>
SebiWrn
added a commit
that referenced
this pull request
May 7, 2024
Co-authored-by: Sebastian <sebwirn@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #1181
Description
Added a Button to exit the settings page. Currently uses browser history but can be extended to use custom history.
Steps for Testing
Prerequisites:
Screenshots