1185-recent-VODs-section-doesnt-show-pinned-public-courses #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinnedCourses are added to recently.
|
Your Testserver will be ready at https://1221.test.live.mm.rbg.tum.de in a few minutes. Logins
|
eslint prettifier error, added an "enter" at line 39
eslint prettifier errors are fixed.
eslint prettifier errors are fixed.
final eslint error is fixed
barisgul15
changed the title
alexanderstephan
approved these changes
Nov 8, 2023
barisgul15
deleted the
1185-recent-VODs-section-doesnt-show-pinned-public-courses
branch
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Update main.ts pinnedCourses are added to recently. * Update main.ts eslint prettifier error, added an "enter" at line 39 * Update main.ts eslint prettifier errors are fixed. * Update main.ts eslint prettifier errors are fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Issue 1185: Recent VODs section doesnt show pinned (public) courses
Description
Before the changes, only user courses were listed for the recently VOD section. Now there is a new array for pinned Courses and if it is detected that user has one or more pinned courses, pinned and user courses are merged into a new array (with eliminating duplicates) and this array is used for the recently VOD section. However a user without any course will still be seeing all public courses in recently VOD section whether he/she has pinned any course or not. That can also be changed to see only pinned courses if desired, but since the probability of a user without any course pinning a course is so low, that feature is not implemented.
Steps for Testing
Screenshots