Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh/advanced logging #1247

Merged
merged 35 commits into from
Dec 18, 2023
Merged

Enh/advanced logging #1247

merged 35 commits into from
Dec 18, 2023

Conversation

SebiWrn
Copy link
Contributor

@SebiWrn SebiWrn commented Nov 28, 2023

Motivation and Context

Added custom JSON Logger to every package so logging output can be checked easily

Description

Every log now prints a JSON String instead of just a readable text string

Steps for Testing

Run your Instance of gocast

Copy link

Your Testserver will be ready at https://1247.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@alexanderstephan
Copy link
Collaborator

Just so we don't forget it: If you update the Go version, don't forget to update

go-version: [ 1.20.x ]
as well.

@SebiWrn SebiWrn enabled auto-merge (squash) December 13, 2023 14:58
Copy link
Contributor

@DawinYurtseven DawinYurtseven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of it looks good just that one line in the dockerfile should be reverted

Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@DawinYurtseven DawinYurtseven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay hast die dockerfile reverted und sieht aus das du nur die logger replaced hast und die go version auf 1.21 gesetzt hast. sieht gut aus soweit ich sehe

@SebiWrn SebiWrn merged commit 7e37435 into dev Dec 18, 2023
8 checks passed
@SebiWrn SebiWrn deleted the enh/advanced-logging branch December 18, 2023 16:11
@SebiWrn SebiWrn restored the enh/advanced-logging branch December 19, 2023 11:17
SebiWrn added a commit that referenced this pull request May 7, 2024
* Minor changes in user-settings, still some errors in removing parts

* Added custom setting to add custom speeds for playback and implemented these into video player

* Full rewrite of the logging in the api folder

* Fixed a bug in statistics.go

* Changed logging in dao and tumlive

* Finished rewriting logs everywhere but in the worker

* Minor changes in user-settings, still some errors in removing parts

* Added custom setting to add custom speeds for playback and implemented these into video player

* Full rewrite of the logging in the api folder

* Fixed a bug in statistics.go

* Changed logging in dao and tumlive

* Finished rewriting logs everywhere but in the worker

* Added json logging to dao and in email.go, go upgraded to 1.21, added slogGorm package

* Merged locally

* Changed Dockerfile to work with multiple files in cmd/tumlive

* Fixed a bug

* Fixed a bug

* Fixed some version things

* Fixed build errors

* Fixed bug in worker

* Fixed another bug

* Testing another change in go.work

* Updated go.sum

* Fixed go.work

* Updated to go 1.21.5

* Removed autobuild

* Added correct make targets to build

* Fixed some more bugs

* Changed everything to 1.21 instead of 1.21.5

* Removed toolchain directive

* Added toolchain directive with new version

* Last try with toolchain directive

* Fixed pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants