Revise golangci-lint configuration #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Testserver will be ready at https://1274.test.live.mm.rbg.tum.de in a few minutes. Logins
|
|
The issues somehow differ from what I am seeing locally, investigating... |
|
Works as it should now. 🎉 |
kordianbruck
approved these changes
Dec 19, 2023
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Linter fixup and demo * Configure workflow separately * Test to break the CI again * Revert "Test to break the CI again" This reverts commit 93fd948.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previously, the linter started linting starting from the moving branch
HEAD.Of course, this is always the latest commit, rendering the linter ineffective.
Description
Update the golangci configuration to mitigate this problem. Besides, I remove
depguardas it seems a bit over the top.We now actually only highlight new issues now, i.e., issues that will come on top of
dev.Feel free to run it locally on older changes to find meaningful issues.
Steps for Testing
None. A passing CI should be enough.