Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup chat close on esc added. #1281

Merged
merged 2 commits into from
Dec 28, 2023
Merged

Conversation

barisgul15
Copy link
Contributor

Motivation and Context

closes #1280

Description

add an event listener so that popup chat is closed when esc is clicked

Steps for Testing

Prerequisites:

  1. Log in
  2. Navigate to a lecture recording with chat enabled or create one
  3. Open popup chat and click esc and check whether it closes the popup chat browser or not

Screenshots

@barisgul15 barisgul15 linked an issue Dec 25, 2023 that may be closed by this pull request
Copy link

Your Testserver will be ready at https://1281.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@alexanderstephan
Copy link
Collaborator

I think that this is a convenient feature. 👍 But we should document that shortcut somewhere, right? Maybe we could have a couple other shortcuts here which are then explained in a small dialog box. I imagine a small icon with a keyboard logo. It could be a component that we could reuse on other parts of the website where we use shortcuts.

@alexanderstephan
Copy link
Collaborator

Maybe one other note. Commit messages should not end with a dot (.) and use sentence case.

@barisgul15
Copy link
Contributor Author

I think that this is a convenient feature. 👍 But we should document that shortcut somewhere, right? Maybe we could have a couple other shortcuts here which are then explained in a small dialog box. I imagine a small icon with a keyboard logo. It could be a component that we could reuse on other parts of the website where we use shortcuts.

While implementing that I was also asking myself how will user gonna know that popup chat can be closed by pressing esc but could not think of a convenient idea. I think your suggestion makes sense. If its ok for you, I can create a new issue about it and work on it?

Copy link
Contributor

@SebiWrn SebiWrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@SebiWrn SebiWrn merged commit 2f203ba into dev Dec 28, 2023
8 checks passed
@SebiWrn SebiWrn deleted the 1280-close-popup-chat-by-clicking-esc branch December 28, 2023 13:38
SebiWrn added a commit that referenced this pull request Dec 29, 2023
* popup chat close on esc added.

* Update popup-chat.gohtml

---------

Co-authored-by: Sebastian <sebiwrn@web.de>
DawinYurtseven added a commit that referenced this pull request Jan 11, 2024
* Added list view -> not finished yet

* Enh/transcoding issues (#1283)

* added boolean to commandBuild and lowered probesize a bit to see if it works now

* Removed checks for isSelfStream because not used

* Removed deprecated for isSelfStream

* Set isSelfStream to true for selfstreams

* added boolean to commandBuild and lowered probesize a bit to see if it works now

---------

Co-authored-by: Dawin Yurtseven <dawinyurtseven@gmail.com>

* popup chat close on esc added. (#1281)

* popup chat close on esc added.

* Update popup-chat.gohtml

---------

Co-authored-by: Sebastian <sebiwrn@web.de>

* Set GIN to only log above level 400 (#1271)

* Show worker version on worker dashboard (#1285)

* Updated storage

* Lint fix

* Update course.ts

changed if else writing style

* Lint fix

---------

Co-authored-by: Dawin Yurtseven <dawinyurtseven@gmail.com>
Co-authored-by: barisgul15 <70471039+barisgul15@users.noreply.github.com>
Co-authored-by: Dawin <73998830+DawinYurtseven@users.noreply.github.com>
SebiWrn added a commit that referenced this pull request May 7, 2024
* popup chat close on esc added.

* Update popup-chat.gohtml

---------

Co-authored-by: Sebastian <sebiwrn@web.de>
SebiWrn added a commit that referenced this pull request May 7, 2024
* Added list view -> not finished yet

* Enh/transcoding issues (#1283)

* added boolean to commandBuild and lowered probesize a bit to see if it works now

* Removed checks for isSelfStream because not used

* Removed deprecated for isSelfStream

* Set isSelfStream to true for selfstreams

* added boolean to commandBuild and lowered probesize a bit to see if it works now

---------

Co-authored-by: Dawin Yurtseven <dawinyurtseven@gmail.com>

* popup chat close on esc added. (#1281)

* popup chat close on esc added.

* Update popup-chat.gohtml

---------

Co-authored-by: Sebastian <sebiwrn@web.de>

* Set GIN to only log above level 400 (#1271)

* Show worker version on worker dashboard (#1285)

* Updated storage

* Lint fix

* Update course.ts

changed if else writing style

* Lint fix

---------

Co-authored-by: Dawin Yurtseven <dawinyurtseven@gmail.com>
Co-authored-by: barisgul15 <70471039+barisgul15@users.noreply.github.com>
Co-authored-by: Dawin <73998830+DawinYurtseven@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close popup chat by clicking esc
3 participants