Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1182 more replayplayback speed options #1282

Merged
merged 10 commits into from
Jan 10, 2024

Conversation

SebiWrn
Copy link
Contributor

@SebiWrn SebiWrn commented Dec 27, 2023

Motivation and Context

Add up to 3 custom playback speeds for students to match the lecture speed.

Steps for Testing

Prerequisites:

  • 1 Account
  1. Log in
  2. Navigate to settings
  3. Add a custom playback speed
  4. Navigate to a livestream and use your setting

Screenshots

image

@SebiWrn SebiWrn linked an issue Dec 27, 2023 that may be closed by this pull request
Copy link
Contributor

@DawinYurtseven DawinYurtseven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add back the comments that were there before.

@SebiWrn SebiWrn enabled auto-merge (squash) January 9, 2024 19:54
Copy link
Contributor

@YiranDuan721 YiranDuan721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfect as far as I can think of.
This is what I personally really need as a user, thanks for the change ;)

@SebiWrn SebiWrn merged commit f7fe0dc into dev Jan 10, 2024
8 checks passed
@SebiWrn SebiWrn deleted the 1182-more-replayplayback-speed-options branch January 10, 2024 23:28
SebiWrn added a commit that referenced this pull request May 7, 2024
* Minor changes in user-settings, still some errors in removing parts

* Added custom setting to add custom speeds for playback and implemented these into video player

* Minor changes in user-settings, still some errors in removing parts

* Added custom setting to add custom speeds for playback and implemented these into video player

* Added hard maximum of 3 custom speeds

* Lint fix

* Golangci lint fix

* Added comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More replay/playback speed options
3 participants