-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1275 description markdown rendering not working #1297
Merged
YiranDuan721
merged 4 commits into
dev
from
1275-description-markdown-rendering-not-working
Jan 11, 2024
Merged
1275 description markdown rendering not working #1297
YiranDuan721
merged 4 commits into
dev
from
1275-description-markdown-rendering-not-working
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… less" to avoid confusion. Now the button reads "Show more" when the full description is not shown, and "Show less" when the full description is shown.
…o span to preserve its formatting.
Your Testserver will be ready at https://1297.test.live.mm.rbg.tum.de in a few minutes. Logins
|
… of title + 1 line of plain text)
…tion environment, allowing the element's height to be accurately calculated even with blank lines; Remove debug code.
SebiWrn
approved these changes
Jan 11, 2024
YiranDuan721
deleted the
1275-description-markdown-rendering-not-working
branch
January 11, 2024 14:01
SebiWrn
pushed a commit
that referenced
this pull request
May 7, 2024
* Course description on the watching page: Switch "Show more" and "Show less" to avoid confusion. Now the button reads "Show more" when the full description is not shown, and "Show less" when the full description is shown. * Change the hidden field containing the video description from input to span to preserve its formatting. * Collapse video description also when it is too high (more than 1 line of title + 1 line of plain text) * The hidden element holding the description simulates the real description environment, allowing the element's height to be accurately calculated even with blank lines; Remove debug code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos
Screenshots
Before:
After: