Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added skip silence hotkey #1303

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Added skip silence hotkey #1303

merged 1 commit into from
Jan 10, 2024

Conversation

SebiWrn
Copy link
Contributor

@SebiWrn SebiWrn commented Jan 9, 2024

Motivation and Context

Skip Silence should have a hotkey

Description

Added hotkey "s" and "S" as hotkey for skipping silence

Steps for Testing

  1. Navigate to a Livestream with silence
  2. Press "s" or "S"

@SebiWrn SebiWrn self-assigned this Jan 9, 2024
@SebiWrn SebiWrn linked an issue Jan 9, 2024 that may be closed by this pull request
"Skip pause" should get keybind #1293
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

Your Testserver will be ready at https://1303.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3		 student1
student2		 student2
student3		 student1
student2

@SebiWrn SebiWrn enabled auto-merge (squash) January 9, 2024 19:54
YiranDuan721
YiranDuan721 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@YiranDuan721 YiranDuan721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfect by me locally

@SebiWrn SebiWrn merged commit 7a7cfab into dev Jan 10, 2024
9 checks passed
@SebiWrn SebiWrn deleted the 1293-skip-pause-should-get-keybind branch January 10, 2024 15:17
SebiWrn added a commit that referenced this pull request May 7, 2024
@SebiWrn
Added skip silence hotkey (#1303)
9cf26a0 
Added hotkey for skipping silence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YiranDuan721 YiranDuan721 YiranDuan721 approved these changes

@alexanderstephan alexanderstephan Awaiting requested review from alexanderstephan

@DawinYurtseven DawinYurtseven Awaiting requested review from DawinYurtseven

Assignees

@SebiWrn SebiWrn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Skip pause" should get keybind
2 participants
@SebiWrn @YiranDuan721