-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video heatmap visuals #576
Conversation
…t-popular-parts-of-videos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is one of the coolest features implemented in the last couple of months. Great job. 🫡
Potential bug I found: When skipping forward (or backwards) the heat map wiggles a bit (Using Chrome):
wiggle.mov
Also make sure to merge dev
properly into this branch, so that the bug fixed in #852 isn't reintroduced.
@MatthiasReumann the wiggeling is because of the time label that changes its length. It also changes the length of the seekbar, thats why the heatmap changes its size too. I didnt want to change so much inside video.js, but I see that this can be somehow anoying, what do you think, should we mess with videojs css and fix it, what do you think? :) |
Ouh. Definitely not worth the time. |
Yes lets go for a followup PR 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks again 🚀
Splitted the heatmap implementation into two parts:
This Pullrequest only contain the visuals to display the heatmap
Many Data Points:
Few Data Points: