Custom Branding #665
Merged
Custom Branding #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add copy of opptional branding folder for - manifest.json - favicon.ico - logo.svg
Add Customization to README.md Add branding-example folder
Custom branding for titles, etc. Add branding.yaml to /branding-example Update templates
Copied from config.go for config.yaml
Add branding.yaml information
Add branding to volumes
5 tasks
MatthiasReumann
requested review from
joschahenningsen,
alexanderstephan and
mono424
Dockerfile
Outdated
Comment on lines
6
to
9
| # Copy branding (if exists) | ||
| COPY 'brandin[g]/manifest.json' /app/web/assets/ | ||
| COPY 'brandin[g]/favicon.ico' /app/web/assets/ | ||
| COPY 'brandin[g]/logo.svg' /app/web/assets/img/ |
There was a problem hiding this comment.
Would it be possible to mount these with a volume like the branding.yaml?
End users should not be required to build the app themselves imo.
Changes look great otherwise!
There was a problem hiding this comment.
Good idea. Will look into it!
Make static files more "dynamic" Use embedded FS for favicon.ico Include branding
joschahenningsen
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/logo.svgand/manifest.jsonbranding.gowhich reads abranding.yamlfile for the customization of titles, etc.How it works
Mount
brandingfolder. Specify the folder inconfig.yaml. The custom logo and favicon should be visible.If a
branding.yamlis provided at the same location asconfig.yaml, it will be used for titles, etc.If the
brandingfolder doesn't exist the default TUM-Live configuration is used.