-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meilisearch for prefetched courses #833
Conversation
Your Testserver will be ready at https://833.test.live.mm.rbg.tum.de in a few minutes. |
Thanks to @CommanderStorm for the input on this :) |
When run |
I think I get the error |
Hm I thought the ?primaryKey might do the trick 🤔 |
@alexanderstephan I updated the zip file, it should work with the new one :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, it really works great. 🎉 The code looks also flawless. 👍
Motivation and Context
The current sql fulltext search is not user friendly. To overcome this issue we can try using meilisearch as discussed here: #814 It even handles typos very well.
Description
The courses are prefetched and stored in a newly introduced search engine instead of the database. From there we can simply query them.
Steps for Testing
Run a local instance of meilisearch like this:
Download and extract this json document:
prefetchedCourses.zip
Push it to meilisearch as demo data:
Test the search when creating a course
The import can only be tested with a tum online token so you'll need to trust me on this :P
Screenshots
2022-12-02.15-13-22.mp4