Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitles w/o admin #898

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Add subtitles w/o admin #898

merged 2 commits into from
Jan 26, 2023

Conversation

MatthiasReumann
Copy link
Collaborator

@MatthiasReumann MatthiasReumann commented Jan 25, 2023

Motivation and Context

  • Add subtitles model and dao
  • Add /api/stream/:id/subtitles/:lang endpoint + tests
  • Dynamically load subtitles on the frontend

Steps for Testing

Insert subtitles to database for stream

  • 2 Livestream(s) one with, one without subtitles
  1. Navigate to the Livestream with subtitles
  2. Subtitles should be activateable
  3. Navigate to the livestream without subtitles
  4. No subtitle button should be visible

Further Information

Not sure, but #891 might break the subtitles in split view. (@mono424)

@github-actions
Copy link

Your Testserver will be ready at https://898.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

Copy link
Sponsor Member

@joschahenningsen joschahenningsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks a ton! ❤️

@joschahenningsen joschahenningsen merged commit 77f8b54 into dev Jan 26, 2023
@joschahenningsen joschahenningsen deleted the enh/subtitles-wo-admin branch January 26, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants