Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow mp4 downloads from hls edge server #931

Merged
merged 7 commits into from
Apr 23, 2023
Merged

Conversation

joschahenningsen
Copy link
Sponsor Member

@joschahenningsen joschahenningsen commented Feb 22, 2023

Motivation and Context

Currently we have two versions of the same video:

  • the hls stream intended for streaming
  • the mp4 file intended for downloads

This is unneccesarry and a huge waste of resources. This PR allows the edge server to deliver a hls stream by combining the segments into one mp4.

Steps for testing:

  • start TUM-Live, a worker and the vod service
  • upload a vod
  • go to admin panel and download vod from edge server

@github-actions
Copy link

Your Testserver will be ready at https://931.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3
student1
student2
student2
student3
student1
student2

@joschahenningsen joschahenningsen marked this pull request as ready for review April 23, 2023 18:12
@joschahenningsen joschahenningsen merged commit 791106a into dev Apr 23, 2023
@joschahenningsen joschahenningsen deleted the edge-downloads branch April 23, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant