Feature/code cleanup #573
Merged
Feature/code cleanup #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TadasBaltrusaitis
added a commit
that referenced
this pull request
Nov 29, 2018
* Removing code duplication and getting rid of some C++ warnings due to float/double and signed/unsigned mixing. * Fixing the screenshot functionality. * Feature/code cleanup (#573) * Header guard cleanup (making sure naming is compliant with C++ standards and consistent). * Removing un-needed nullptr checks. * Removing SSE warnings for x64 builds (as SSE is enabled by default no need for a flag) * Reverting Mat deletion * Adding Visual Studio 2017 solution * Feature/code cleanup (#580) - name of revision - better scripts for model download (not only in Dropbox also OneDrive) * Update the OpenCV constants to the corresponding ones in cpp namespace. (#578) Updating OpenCV macros. * Slight change in packaging code (use a shared download script). * Removing TBB dependency (#590) Removing a TBB dependence for code parallelization (done through OpenCV's parralel_for_ * Updating OpenBLAS (#594) Updating the 64 bit OpenBLAS version for Windows to 0.3.3 (50% perf improvement on certain machines) * Ability to specify output image formats and removing unused quiet parameter. * Update Windows download script (#608) (#610) - Automatically choose correct path to the model files so that it works for both, source code compilation and binary use - Use absolute paths in the system exists methods * Updating version. * Packaging code update.
ratgen
pushed a commit
to ratgen/OpenFace
that referenced
this pull request
Jul 7, 2022
* Removing code duplication and getting rid of some C++ warnings due to float/double and signed/unsigned mixing. * Fixing the screenshot functionality. * Feature/code cleanup (TadasBaltrusaitis#573) * Header guard cleanup (making sure naming is compliant with C++ standards and consistent). * Removing un-needed nullptr checks. * Removing SSE warnings for x64 builds (as SSE is enabled by default no need for a flag) * Reverting Mat deletion * Adding Visual Studio 2017 solution * Feature/code cleanup (TadasBaltrusaitis#580) - name of revision - better scripts for model download (not only in Dropbox also OneDrive) * Update the OpenCV constants to the corresponding ones in cpp namespace. (TadasBaltrusaitis#578) Updating OpenCV macros. * Slight change in packaging code (use a shared download script). * Removing TBB dependency (TadasBaltrusaitis#590) Removing a TBB dependence for code parallelization (done through OpenCV's parralel_for_ * Updating OpenBLAS (TadasBaltrusaitis#594) Updating the 64 bit OpenBLAS version for Windows to 0.3.3 (50% perf improvement on certain machines) * Ability to specify output image formats and removing unused quiet parameter. * Update Windows download script (TadasBaltrusaitis#608) (TadasBaltrusaitis#610) - Automatically choose correct path to the model files so that it works for both, source code compilation and binary use - Use absolute paths in the system exists methods * Updating version. * Packaging code update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ code cleanup