Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(adapters): improve coherence and expose return types #911

Merged
merged 6 commits into from
Aug 18, 2024

Conversation

Balastrong
Copy link
Member

  1. Adapters now share a common params interface to ensure consistency and making it easy to swap between them.
  2. Return type exposed
    FormApi<FormData, ReturnType<typeof zodValidator>> -> FormApi<FormData, ZodValidator>

Copy link

nx-cloud bot commented Aug 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 37b2a23. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Aug 17, 2024

commit: 37b2a23

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@911

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@911

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@911

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@911

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@911

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@911

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@911

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@911

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@911

Open in Stackblitz

More templates

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (5473bb8) to head (37b2a23).
Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   91.55%   88.74%   -2.81%     
==========================================
  Files          21       26       +5     
  Lines         900      933      +33     
  Branches      206      209       +3     
==========================================
+ Hits          824      828       +4     
- Misses         71       99      +28     
- Partials        5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Balastrong Balastrong merged commit 427875d into TanStack:main Aug 18, 2024
6 of 7 checks passed
@Balastrong Balastrong deleted the refactor/validator-adapters branch August 18, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant