Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Sort imports with eslint #5634

Merged
merged 3 commits into from
Jul 16, 2023
Merged

refactor: Sort imports with eslint #5634

merged 3 commits into from
Jul 16, 2023

Conversation

lachlancollins
Copy link
Member

I personally find imports sorted in a consistent order easier to approach, just like how prettier formats code in a consistent way. The rules here are totally flexible but would mean all packages follow the same structure.

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Jul 16, 2023 4:46am

@nx-cloud
Copy link

nx-cloud bot commented Jun 27, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0750784. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --targets=test:eslint,test:lib,test:types,test:build
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 27, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0750784:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (ddf6986) 92.29% compared to head (04a2933) 92.29%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5634   +/-   ##
=======================================
  Coverage   92.29%   92.29%           
=======================================
  Files         112      112           
  Lines        4283     4283           
  Branches     1117     1117           
=======================================
  Hits         3953     3953           
  Misses        309      309           
  Partials       21       21           
Impacted Files Coverage Δ
packages/eslint-plugin-query/src/configs/index.ts 100.00% <ø> (ø)
.../src/rules/exhaustive-deps/exhaustive-deps.rule.ts 100.00% <ø> (ø)
...src/rules/exhaustive-deps/exhaustive-deps.utils.ts 100.00% <ø> (ø)
...-query-object-syntax/prefer-query-object-syntax.ts 96.19% <ø> (ø)
...kages/eslint-plugin-query/src/utils/create-rule.ts 100.00% <ø> (ø)
packages/query-core/src/mutation.ts 94.17% <ø> (ø)
packages/query-core/src/queryCache.ts 100.00% <ø> (ø)
packages/query-core/src/tests/utils.ts 88.57% <ø> (ø)
...s/query-persist-client-core/src/__tests__/utils.ts 89.47% <ø> (ø)
packages/query-sync-storage-persister/src/index.ts 85.00% <ø> (ø)
... and 59 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TkDodo
Copy link
Collaborator

TkDodo commented Jun 27, 2023

I agree, but it's gonna cause so many conflicts when merging back to alpha 😭

Maybe we should this once v5 is released and we have only one branch to maintain?

@lachlancollins
Copy link
Member Author

I agree, but it's gonna cause so many conflicts when merging back to alpha 😭

Maybe we should this once v5 is released and we have only one branch to maintain?

@TkDodo I was just going to merge main into alpha and only keep the changes to .eslintrc.cjs, then re-run eslint fix. I'm hoping this would actually mean there would be fewer conflicts between v4 and v5!

@TkDodo
Copy link
Collaborator

TkDodo commented Jun 27, 2023

okay, let me just ship the fix for 5538 first. It has two PRs - one for main and one for alpha.

@lachlancollins lachlancollins merged commit 9c721e5 into TanStack:main Jul 16, 2023
6 of 7 checks passed
@lachlancollins lachlancollins deleted the eslint-sort branch July 16, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants