Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: id building was not consistent when using deep accessorKey (4754) #5430

Merged
merged 3 commits into from
Aug 3, 2024

Conversation

Roman86
Copy link
Contributor

@Roman86 Roman86 commented Mar 22, 2024

fixes #4754

Copy link

nx-cloud bot commented Aug 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f68263c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Aug 3, 2024

commit: f68263c

pnpm add https://pkg.pr.new/@tanstack/angular-table@5430
pnpm add https://pkg.pr.new/@tanstack/lit-table@5430
pnpm add https://pkg.pr.new/@tanstack/match-sorter-utils@5430
pnpm add https://pkg.pr.new/@tanstack/qwik-table@5430
pnpm add https://pkg.pr.new/@tanstack/react-table@5430
pnpm add https://pkg.pr.new/@tanstack/react-table-devtools@5430
pnpm add https://pkg.pr.new/@tanstack/solid-table@5430
pnpm add https://pkg.pr.new/@tanstack/svelte-table@5430
pnpm add https://pkg.pr.new/@tanstack/table-core@5430
pnpm add https://pkg.pr.new/@tanstack/vue-table@5430

Open in Stackblitz

More templates

@KevinVandy KevinVandy merged commit 84cf73a into TanStack:main Aug 3, 2024
5 checks passed
@xkomiks
Copy link

xkomiks commented Aug 4, 2024

@KevinVandy, @Roman86 why are you prefer use _ for id? And why is this included in library standard if the previous version had .

@KevinVandy
Copy link
Member

This PR just changed from using replace to replaceAll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

id building is not consistent when using accessorKey
3 participants