Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adjust markdown links to correct level #255

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix: Adjust markdown links to correct level #255

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24c57b8
fix: Adjust markdown links to correct level
lachlancollins Jul 18, 2024
c269fb6
Merge branch 'main' into markdown-links
TkDodo Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/components/MarkdownLink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,15 @@
import type { HTMLProps } from 'react'

export function MarkdownLink(props: HTMLProps<HTMLAnchorElement>) {
if ((props as { href: string }).href?.startsWith('http')) {
if (props.href?.startsWith('http')) {
return <a {...props} />

Check warning on line 6 in app/components/MarkdownLink.tsx

View workflow job for this annotation

GitHub Actions / PR 

Anchors must have content and the content must be accessible by a screen reader
}

const relativeHref = props.href?.replace(/([A-Za-z][A-Za-z/_-]+).md/, '../$1')

return (
<Link
to={props.href as any}
to={relativeHref}
params={{}}
{...props}
preload={undefined}
Expand Down
Loading